Skip to content

Mark more tests as requiring network #13378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions news/13378.bugfix.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix missing ``network`` test markings, making the suite pass in offline
environments again.
3 changes: 3 additions & 0 deletions tests/functional/test_config_settings.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
from typing import List, Optional, Tuple
from zipfile import ZipFile

import pytest

from pip._internal.utils.urls import path_to_url

from tests.lib import PipTestEnvironment, create_basic_sdist_for_package
Expand Down Expand Up @@ -179,6 +181,7 @@ def test_backend_sees_config_via_constraint(script: PipTestEnvironment) -> None:
assert json.loads(output) == {"FOO": "Hello"}


@pytest.mark.network
def test_backend_sees_config_via_sdist(script: PipTestEnvironment) -> None:
name, version, project_dir = make_project(script.scratch_path)
dists_dir = script.scratch_path / "dists"
Expand Down
2 changes: 2 additions & 0 deletions tests/functional/test_install.py
Original file line number Diff line number Diff line change
Expand Up @@ -1917,6 +1917,7 @@ def test_double_install(script: PipTestEnvironment) -> None:
assert msg not in result.stderr


@pytest.mark.network
def test_double_install_fail(
script: PipTestEnvironment, resolver_variant: ResolverVariant
) -> None:
Expand Down Expand Up @@ -2677,6 +2678,7 @@ def test_install_pip_prints_req_chain_pypi(script: PipTestEnvironment) -> None:


@pytest.mark.parametrize("common_prefix", ["", "linktest-1.0/"])
@pytest.mark.network
def test_install_sdist_links(script: PipTestEnvironment, common_prefix: str) -> None:
"""
Test installing an sdist with hard and symbolic links.
Expand Down
1 change: 1 addition & 0 deletions tests/functional/test_install_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -417,6 +417,7 @@ def flags(
return flags


@pytest.mark.network
def test_prompt_for_keyring_if_needed(
data: TestData,
cert_factory: CertFactory,
Expand Down
4 changes: 4 additions & 0 deletions tests/functional/test_lock.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import textwrap
from pathlib import Path

import pytest

from pip._internal.utils.compat import tomllib
from pip._internal.utils.urls import path_to_url

Expand Down Expand Up @@ -181,6 +183,7 @@ def test_lock_local_editable_with_dep(
]


@pytest.mark.network
def test_lock_vcs(script: PipTestEnvironment, shared_data: TestData) -> None:
result = script.pip(
"lock",
Expand All @@ -205,6 +208,7 @@ def test_lock_vcs(script: PipTestEnvironment, shared_data: TestData) -> None:
]


@pytest.mark.network
def test_lock_archive(script: PipTestEnvironment, shared_data: TestData) -> None:
result = script.pip(
"lock",
Expand Down