Revert "Merge pull request #12637 from ichard26/refactor/imports" #12676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 71a08a7, reversing changes made to 22142d6. This patch made the pip self-version check import `pip._internal.self_outdated_check` on demand. This blows up when downgrading (and possibly upgrading) pip as it imports the module _after_ the downgrade, which is problematic as the older self-check logic is incompatible with the rest of the pip already loaded into memory.
This was referenced May 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 71a08a7, reversing changes made to 22142d6.
One possible fix for #12675.
This patch made the pip self-version check import
pip._internal.self_outdated_checkon demand. This blows up when downgrading (and possibly upgrading) pip as it imports the module after the downgrade, which is problematic as the older self-check logic is incompatible with the rest of the pip already loaded into memory.