Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade vendored packaging lib #12300

Merged
merged 43 commits into from
May 4, 2024
Merged

Upgrade vendored packaging lib #12300

merged 43 commits into from
May 4, 2024

Commits on May 4, 2024

  1. Upgrade vendored packaging lib

    @sbidoul @pradyunsg
    sbidoul authored and pradyunsg committed May 4, 2024
    Configuration menu
    Copy the full SHA
    47a8480 View commit details
    Browse the repository at this point in the history

  2. Fix test?

    @sbidoul @pradyunsg
    sbidoul authored and pradyunsg committed May 4, 2024
    Configuration menu
    Copy the full SHA
    335f01c View commit details
    Browse the repository at this point in the history

  3. Rename invalid sdists in our test data

    @sbidoul @pradyunsg
    sbidoul authored and pradyunsg committed May 4, 2024
    Configuration menu
    Copy the full SHA
    87bda4b View commit details
    Browse the repository at this point in the history

  4. Fix test following stricter version specifiers parsing

    @sbidoul @pradyunsg
    sbidoul authored and pradyunsg committed May 4, 2024
    Configuration menu
    Copy the full SHA
    3b01221 View commit details
    Browse the repository at this point in the history

  5. Don't use legacy version numbers in tests

    @sbidoul @pradyunsg
    sbidoul authored and pradyunsg committed May 4, 2024
    Configuration menu
    Copy the full SHA
    62215ca View commit details
    Browse the repository at this point in the history

  6. Remove now redundant error detection 

    This specifier syntax check is now done by the packaging library.
    @sbidoul @pradyunsg
    sbidoul authored and pradyunsg committed May 4, 2024
    Configuration menu
    Copy the full SHA
    9dcd269 View commit details
    Browse the repository at this point in the history

  7. Remove various extras normalization workarounds

    @sbidoul @pradyunsg
    sbidoul authored and pradyunsg committed May 4, 2024
    Configuration menu
    Copy the full SHA
    4d70566 View commit details
    Browse the repository at this point in the history

  8. Fix obvious typo in test wheel generator

    @sbidoul @pradyunsg
    sbidoul authored and pradyunsg committed May 4, 2024
    Configuration menu
    Copy the full SHA
    5463bba View commit details
    Browse the repository at this point in the history

  9. Strip Requires-Dist metadata parsed from METADATA files 

    These can contain a leading \n if the requirement was long and wrapped by
email.message.EmailMessage.as_bytes().
    @sbidoul @pradyunsg
    sbidoul authored and pradyunsg committed May 4, 2024
    Configuration menu
    Copy the full SHA
    92cb9c9 View commit details
    Browse the repository at this point in the history

  10. Remove vendored pyparsing

    @sbidoul @pradyunsg
    sbidoul authored and pradyunsg committed May 4, 2024
    Configuration menu
    Copy the full SHA
    04ea0da View commit details
    Browse the repository at this point in the history

  11. Explicitly keep track of canonical extra names with pkg_resources 

    This ensures that the Distribution only exposes canonical forms of the
extras, papering over the lack of PEP 685 support in the vendored
version of `pkg_resources`.
    @pradyunsg
    pradyunsg committed May 4, 2024
    Configuration menu
    Copy the full SHA
    372c616 View commit details
    Browse the repository at this point in the history

  12. Compare Requirement objects rather than requirement strings 

    This ensures that the comparision does not fail due to mismatching extra
normalisation.
    @pradyunsg
    pradyunsg committed May 4, 2024
    Configuration menu
    Copy the full SHA
    e38c2b9 View commit details
    Browse the repository at this point in the history

  13. Do not normalise iter_provided_extras from pkg_resources 

    This is explicitly checked for in the test suite and it isn't strictly
necessary to ensure the correct behaviour. This does expose that the
test mock objects are incomplete so those get a missing `extra`
attribute added.
    @pradyunsg
    pradyunsg committed May 4, 2024
    Configuration menu
    Copy the full SHA
    908e913 View commit details
    Browse the repository at this point in the history

  14. Use extras directly from metadata when using pkg_resources 

    Instead of relying on `pkg_resources`'s internal data structure, use the
metadata has to be constructed regardless to lookup the information
about relevant extras.
    @pradyunsg
    pradyunsg committed May 4, 2024
    Configuration menu
    Copy the full SHA
    5cc540b View commit details
    Browse the repository at this point in the history

  15. Implement PEP 685 on distribution objects directly 

    This uses normalised names across the board for extras, with
comparisions outside this context relying on `packaging`'s support for
the corresponding comparisions.
    @pradyunsg
    pradyunsg committed May 4, 2024
    Configuration menu
    Copy the full SHA
    8d22e80 View commit details
    Browse the repository at this point in the history

  16. Add failing test for index with legacy versions

    @sbidoul @pradyunsg
    sbidoul authored and pradyunsg committed May 4, 2024
    Configuration menu
    Copy the full SHA
    cec49ea View commit details
    Browse the repository at this point in the history

  17. Ignore legacy versions in the package finder

    @sbidoul @pradyunsg
    sbidoul authored and pradyunsg committed May 4, 2024
    Configuration menu
    Copy the full SHA
    b63e279 View commit details
    Browse the repository at this point in the history

  18. Add failing test for package with invalid specifier in dependencies

    @sbidoul @pradyunsg
    sbidoul authored and pradyunsg committed May 4, 2024
    Configuration menu
    Copy the full SHA
    587854a View commit details
    Browse the repository at this point in the history

  19. Discard candidates with invalid dependencies

    @sbidoul @pradyunsg
    sbidoul authored and pradyunsg committed May 4, 2024
    Configuration menu
    Copy the full SHA
    bf8b887 View commit details
    Browse the repository at this point in the history

  20. Add failing test for uninstallation of dist with legacy version

    @sbidoul @pradyunsg
    sbidoul authored and pradyunsg committed May 4, 2024
    Configuration menu
    Copy the full SHA
    c44c6a4 View commit details
    Browse the repository at this point in the history

  21. Allow uninstallation of dist with legacy version 

    We do this by adding a version_str property to BaseDistribution,
which allows us to access the version without parsing it.
    @sbidoul @pradyunsg
    sbidoul authored and pradyunsg committed May 4, 2024
    Configuration menu
    Copy the full SHA
    73f6744 View commit details
    Browse the repository at this point in the history

  22. Refactor test

    @sbidoul @pradyunsg
    sbidoul authored and pradyunsg committed May 4, 2024
    Configuration menu
    Copy the full SHA
    0563132 View commit details
    Browse the repository at this point in the history

  23. Add failing test for pip list in presence of legacy version

    @sbidoul @pradyunsg
    sbidoul authored and pradyunsg committed May 4, 2024
    Configuration menu
    Copy the full SHA
    27807fb View commit details
    Browse the repository at this point in the history

  24. Fix pip list in presence of installed legacy versions

    @sbidoul @pradyunsg
    sbidoul authored and pradyunsg committed May 4, 2024
    Configuration menu
    Copy the full SHA
    0529c04 View commit details
    Browse the repository at this point in the history

  25. Add failing test for pip freeze in presence of legacy version

    @sbidoul @pradyunsg
    sbidoul authored and pradyunsg committed May 4, 2024
    Configuration menu
    Copy the full SHA
    93e52cf View commit details
    Browse the repository at this point in the history

  26. Fix pip freeze in presence of legacy version

    @sbidoul @pradyunsg
    sbidoul authored and pradyunsg committed May 4, 2024
    Configuration menu
    Copy the full SHA
    a28d13a View commit details
    Browse the repository at this point in the history

  27. Add failing test for pip show of legacy version

    @sbidoul @pradyunsg
    sbidoul authored and pradyunsg committed May 4, 2024
    Configuration menu
    Copy the full SHA
    be652aa View commit details
    Browse the repository at this point in the history

  28. Fix pip show of legacy version

    @sbidoul @pradyunsg
    sbidoul authored and pradyunsg committed May 4, 2024
    Configuration menu
    Copy the full SHA
    8f97eb5 View commit details
    Browse the repository at this point in the history

  29. Upgrade packaging to 24.0

    @sbidoul @pradyunsg
    sbidoul authored and pradyunsg committed May 4, 2024
    Configuration menu
    Copy the full SHA
    08ae751 View commit details
    Browse the repository at this point in the history

  30. Add news

    @sbidoul @pradyunsg
    sbidoul authored and pradyunsg committed May 4, 2024
    Configuration menu
    Copy the full SHA
    196d536 View commit details
    Browse the repository at this point in the history

  31. Add test sdist that requires invalid version

    @sbidoul @pradyunsg
    sbidoul authored and pradyunsg committed May 4, 2024
    Configuration menu
    Copy the full SHA
    83e77bf View commit details
    Browse the repository at this point in the history

  32. Ignore all candidates of a version when one has invalid metadata 

    We do this to avoid needlessly building a sdist when
we have determined that a wheel has invalid metadata.
    @sbidoul @pradyunsg
    sbidoul authored and pradyunsg committed May 4, 2024
    Configuration menu
    Copy the full SHA
    b458d3e View commit details
    Browse the repository at this point in the history

  33. Simplify 

    Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
    @sbidoul @uranusjr @pradyunsg
    2 people authored and pradyunsg committed May 4, 2024
    Configuration menu
    Copy the full SHA
    350c980 View commit details
    Browse the repository at this point in the history

  34. Don't create a list when an iterator is sufficient

    @sbidoul @pradyunsg
    sbidoul authored and pradyunsg committed May 4, 2024
    Configuration menu
    Copy the full SHA
    f4b821c View commit details
    Browse the repository at this point in the history

  35. Rename version_str to raw_version for consistency with raw_name

    @sbidoul @pradyunsg
    sbidoul authored and pradyunsg committed May 4, 2024
    Configuration menu
    Copy the full SHA
    c50290e View commit details
    Browse the repository at this point in the history

  36. Add failing test for pip show of dist with legacy specifier

    @sbidoul @pradyunsg
    sbidoul authored and pradyunsg committed May 4, 2024
    Configuration menu
    Copy the full SHA
    00edcf4 View commit details
    Browse the repository at this point in the history

  37. Add iterator of raw dependencie (Requires-Dist) to BaseDistribution

    @sbidoul @pradyunsg
    sbidoul authored and pradyunsg committed May 4, 2024
    Configuration menu
    Copy the full SHA
    f24fa66 View commit details
    Browse the repository at this point in the history

  38. Fix pip show of dist with legacy dependency specifiers

    @sbidoul @pradyunsg
    sbidoul authored and pradyunsg committed May 4, 2024
    Configuration menu
    Copy the full SHA
    d85efce View commit details
    Browse the repository at this point in the history

  39. Clarify warning messages 

    Dependencies should be more precise than requirements;
    @sbidoul @pradyunsg
    sbidoul authored and pradyunsg committed May 4, 2024
    Configuration menu
    Copy the full SHA
    4052f6a View commit details
    Browse the repository at this point in the history

  40. Clarify test packages README

    @sbidoul @pradyunsg
    sbidoul authored and pradyunsg committed May 4, 2024
    Configuration menu
    Copy the full SHA
    edc98cd View commit details
    Browse the repository at this point in the history

  41. Add a failing test for upgrading a distribution with an invalid version

    @sbidoul @pradyunsg
    sbidoul authored and pradyunsg committed May 4, 2024
    Configuration menu
    Copy the full SHA
    4bb5085 View commit details
    Browse the repository at this point in the history

  42. Add a failing test for upgrading a distribution with invalid metadata

    @sbidoul @pradyunsg
    sbidoul authored and pradyunsg committed May 4, 2024
    Configuration menu
    Copy the full SHA
    c51fb4f View commit details
    Browse the repository at this point in the history

  43. Fix test_show_require_invalid_version with pkg_resources backend 

    The pkg_ressources metadata backend does not suffer from invalid metadata in this test case.
    @sbidoul @pradyunsg
    sbidoul authored and pradyunsg committed May 4, 2024
    Configuration menu
    Copy the full SHA
    84ad55a View commit details
    Browse the repository at this point in the history