Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update search command docs #12271

Merged
merged 1 commit into from
Sep 10, 2023
Merged

Update search command docs #12271

merged 1 commit into from
Sep 10, 2023

Conversation

shahar1
Copy link
Contributor

@shahar1 shahar1 commented Sep 8, 2023

Fixes: #12059

@chrysle
Copy link
Contributor

chrysle commented Sep 9, 2023

Please see #12207 (comment) concerning removing the whole docs.

@shahar1
Copy link
Contributor Author

shahar1 commented Sep 9, 2023

Please see #12207 (comment) concerning removing the whole docs.

I see, so it may be better to restore the content and add the deprecation comment regarding the PyPi index?
IMO there is a place for some clarification about that in the docs as the issue's OP suggests.

@chrysle
Copy link
Contributor

chrysle commented Sep 9, 2023

I see, so it may be better to restore the content and add the deprecation comment regarding the PyPi index?

I think that is what is suggested in the issue.

Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for filing this! I have a few suggestions, to align better with the style of the rest of the documentation and to fix a couple of minor inconsistencies with the situation here.

docs/html/cli/pip_search.rst Outdated Show resolved Hide resolved
docs/html/cli/pip_search.rst Outdated Show resolved Hide resolved
docs/html/cli/pip_search.rst Outdated Show resolved Hide resolved
news/12059.doc.rst Outdated Show resolved Hide resolved
@shahar1
Copy link
Contributor Author

shahar1 commented Sep 10, 2023

@pradyunsg Thanks for the review, adopted your suggestions :)

@chrysle
Copy link
Contributor

chrysle commented Sep 10, 2023

I think the usage should be kept?

@pradyunsg pradyunsg merged commit 83ca10a into pypa:main Sep 10, 2023
10 checks passed
@JamesParrott
Copy link

Thanks @shahar1 and @pradyunsg. Much appreciated :).

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shouldn't the docs mention pip search is deprecated on PyPi?
4 participants