Parse out extras when selecting from constraints #12025
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Entries in constraints do not (cannot) contain extras, so when we try to select from them we must remove the extras. Those parsed extras should be attached back to the candidates after they are selected from the constraints.
Member
Author
|
Edit: Seems to work now, whatever GitHub was having issues with has been resolved. |
Member
|
@uranusjr Any particular reason this isn't merged yet (other than the lack of a review)? It'd be good to see your old work land at some point :) |
Member
Author
|
I think I just forgot. Will try to pick it up. |
Member
Author
|
Main has diverged enough it’s not practical to rebase. I’ll need to start over. |
ichard26
added
the
state: up for grabs (PR)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entries in constraints do not (cannot) contain extras, so when we try to select from them we must remove the extras. Those parsed extras should be attached back to the candidates after they are selected from the constraints.
Fix #12018.
The debugging part is much more interesting than actually fixing the issue.