Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate download_info.info.hashes in install report for direct URL archives #11949

Merged
merged 5 commits into from
Apr 14, 2023

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Apr 11, 2023

fixes #11948

In a followup I'll further clean up legacy uses of the direct URL hash key.

@sbidoul sbidoul added this to the 23.1 milestone Apr 11, 2023
@sbidoul sbidoul changed the title Generate download_info.info.hashes in installation for direct URL archives Generate download_info.info.hashes in install report for direct URL archives Apr 11, 2023
@sbidoul
Copy link
Member Author

sbidoul commented Apr 13, 2023

This one is ready to go in 23.1 and fairly straightforward. I'll merge tomorrow if there no comments before.

Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections to the patch. This reminds me though, is there a writeup on the hash and hashes compatibility pair? Last time I wanted to work on this part of the code base, trying to figure out how the two attributes interact cost me a ton of time. Some docstrings or comments would help greatly.

@sbidoul
Copy link
Member Author

sbidoul commented Apr 14, 2023

No objections to the patch. This reminds me though, is there a writeup on the hash and hashes compatibility pair? Last time I wanted to work on this part of the code base, trying to figure out how the two attributes interact cost me a ton of time. Some docstrings or comments would help greatly.

@uranusjr We are a bit in an in-between situation with hash and hashes indeed. I have follow-ups in the work in this area that should clarify this.

Thanks for the review again :)

@sbidoul sbidoul merged commit f7787f8 into pypa:main Apr 14, 2023
@sbidoul sbidoul deleted the hash2hashes-sbi branch April 14, 2023 06:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install report download_info.info.hashes missing for direct URL archives without link hash
2 participants