Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use default setuptools behaviour in our tests #11293

Merged
merged 2 commits into from
Jul 23, 2022
Merged

Use default setuptools behaviour in our tests #11293

merged 2 commits into from
Jul 23, 2022

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Jul 23, 2022

Our tests should pass without configuring setuptools in legacy mode.

Let us see if this reveals #11294.

🙈

@sbidoul
Use default setuptools behaviour in our tests
7b96a3c 
Our tests should pass without configuring setuptools in legacy mode.
@sbidoul sbidoul added the skip news Does not need a NEWS file entry (eg: trivial changes) label Jul 23, 2022
@sbidoul sbidoul marked this pull request as ready for review July 23, 2022 15:10
@sbidoul
Copy link
Member Author

sbidoul commented Jul 23, 2022

Let us see if this reveals #11294.

I'm afraid it does not. So this PR can be merged and I guess a new test is needed to reveal #11294.

@sbidoul sbidoul closed this Jul 23, 2022
@sbidoul sbidoul reopened this Jul 23, 2022
@pradyunsg
Copy link
Member

[Change something so tests are not skipped](/pypa/pip/pull/11293/commits/a8d29f72070b643d08f51bc13d1f3ebe6cf68e7e)

Alternatively, should we add noxfile.py to the CI triggers for tests?

pip/.github/workflows/ci.yml

Lines 49 to 53 in 9351efd

tests:
# Anything that's touching code-related stuff
- ".github/workflows/ci.yml"
- "src/**"
- "tests/**"

pradyunsg
pradyunsg approved these changes Jul 23, 2022
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving tentatively, assuming that CI is green when this passes.

@sbidoul sbidoul merged commit 3623d8c into pypa:main Jul 23, 2022
@sbidoul sbidoul deleted the testsuite-without-stdlib-distutils branch July 23, 2022 15:54
@sbidoul sbidoul added this to the 22.2.1 milestone Jul 23, 2022
@sbidoul sbidoul added the type: maintenance Related to Development and Maintenance Processes label Jul 23, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes

Assignees
No one assigned
Labels
skip news Does not need a NEWS file entry (eg: trivial changes) type: maintenance Related to Development and Maintenance Processes
Projects
None yet
Milestone
22.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@sbidoul @pradyunsg