Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade vendored Requests and urllib3 #10759

Merged
merged 2 commits into from
Jan 21, 2022

Conversation

nateprewitt
Copy link
Member

@nateprewitt nateprewitt commented Jan 3, 2022

This PR will update the vendored copy of Requests to the latest release, 2.27.1. Full release notes can be found here.

I've updated the patch to remove part of a recent change around simplejson exception handling since pip already patches this functionality out.

I've also included the most recent release of urllib3 1.26.8 since we're already touching the networking dependency stack.

@nateprewitt nateprewitt changed the title Upgrade vendored Requests to 2.27.0 Upgrade vendored Requests to 2.27.1 Jan 5, 2022
@nateprewitt
Copy link
Member Author

nateprewitt commented Jan 5, 2022

The test failures appear to all be related to #10742. I'm seeing 3 failures with the following error which I don't believe is related. Please let me know if you believe I'm missing something. Otherwise, I believe this is ready. Thanks!

E           TypeError: dist must be a Distribution instance

@nateprewitt nateprewitt marked this pull request as ready for review January 5, 2022 16:34
@DiddiLeija
Copy link
Member

The test failures appear to all be related to #10742. I'm seeing 3 failures with the following error which I don't believe is related. Please let me know if you believe I'm missing something. Otherwise, I believe this is ready. Thanks!

E           TypeError: dist must be a Distribution instance

Yup, that's something out of the control of this PR.

@nateprewitt nateprewitt changed the title Upgrade vendored Requests to 2.27.1 Upgrade vendored Requests and urllib3 Jan 14, 2022
@pradyunsg
Copy link
Member

Thanks @nateprewitt! ^>^

@pradyunsg pradyunsg merged commit 79e6237 into pypa:main Jan 21, 2022
@pradyunsg pradyunsg added this to the 22.0 milestone Jan 21, 2022
@nateprewitt nateprewitt deleted the patch_requests_2_27_0 branch January 21, 2022 15:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants