Correctly ignore osx_framework_user mismatches #10215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The expected 'headers' path is generally: * distutils (old): $PREFIX/include/python3.8/$PROJECT * sysconfig (new): $PREFIX/include/$PROJECT So we should check whether the old value's parent is a pythonX.Y, and the new value's parent matches the old's second-level parent.
|
Pinging people reported this in #10151 for testing. @JRWoodwardMSW @mstankus @RiviniS48 @ondohotola @phriedrich @UnixCro @nicdoye @ChemGuy88 @aah8 |
pradyunsg
approved these changes
Jul 27, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
That's more than good enough for my purposes :-)-O
Thanks again.
greetings, el
On 27/07/2021 14:11, Tzu-ping Chung wrote:
The two patches are independent (or they should be, I’ll resolve any
conflicts if needed) and will both in the next pip release.
[...]
…--
Dr. Eberhard W. Lisse \ / Obstetrician & Gynaecologist
***@***.***NA / * | Telephone: +264 81 124 6733 (cell)
PO Box 8421 Bachbrecht \ / If this email is signed with GPG/PGP
10007, Namibia ;____/ Sect 20 of Act No. 4 of 2019 may apply
Book your Covid-10 Vaccination at https://c19.idtoday.com.na
|
|
Pinging people reported this in #10151 for testing. Use this to install pip from this PR and see if the issue went away: 2021-07-28 08:56:00+0800: @miguelbarao @kielnino 2021-07-30 09:17:00+0800: @afnanenayet @macdeport @hakamadare @HachimanSec @DaryaKorovina @cosmicbabs @BjoAce @katieluii @gtrabanco |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the macOS
--userpart of #10208.The expected 'headers' path is generally:
$PREFIX/include/python3.8/$PROJECT$PREFIX/include/$PROJECTSo we should check whether the old value's parent is a pythonX.Y, and the new value's parent matches the old's second-level parent.