Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor formatting tweaks #10190

Merged
merged 3 commits into from
Jul 23, 2021
Merged

Minor formatting tweaks #10190

merged 3 commits into from
Jul 23, 2021

Conversation

pradyunsg
Copy link
Member

A mix of for-consistency and oh-god-wth-black changes. :)

@pradyunsg
Reformat for clarity
1651e7b 
The implicit string concatenation with black's suboptimal string
handling makes this format clearer
@pradyunsg
Reformat for clarity
5a24fe3 
Avoid implicit string concatenation
@pradyunsg
Reformat for clarity
346824c 
- Avoid implicit concatenation over the same line.
- Prefer parenthesis with implicit concatenation over multiple lines.
@pradyunsg pradyunsg added the skip news Does not need a NEWS file entry (eg: trivial changes) label Jul 23, 2021
@ichard26
Copy link
Member

ichard26 commented Jul 23, 2021 •
edited
Loading

FYI, the issue where multiple string literals being mushed together into a single line but with an awkward space inbetween is a known bug (or design issue, I don't even know at this point :p ) and we're currently trying to fix it by turning on the --experimental-string-processing flag by default.

@pradyunsg
Copy link
Member Author

Are there any known issues with that flag at this time?

@ichard26
Copy link
Member

ichard26 commented Jul 23, 2021 •
edited
Loading

From discussion on Python Discord:

ichard26: [...] the answer to your "is ESP safe?" question is that as far as we know, other than performance issues, it's fine. Black is run over quite a few big projects in CI with ESP enabled and there's no crashes (up in the history you can see us figuring that out - and me testing the last crashing project).

https://discord.com/channels/267624335836053506/846434317021741086/868178127908651019

@uranusjr uranusjr merged commit a196b3b into pypa:main Jul 23, 2021
@pradyunsg pradyunsg deleted the formatting-tweaks branch July 23, 2021 20:15
@pradyunsg
Copy link
Member Author

Thanks @uranusjr! :)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@uranusjr uranusjr uranusjr approved these changes

Assignees
No one assigned
Labels
skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pradyunsg @ichard26 @uranusjr