Complete type annotations in pip/_internal/metadata
#10168
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harupy
changed the title
pip/_internal/metadatapip/_internal/metadata
|
@uranusjr @pradyunsg Could you review this PR? |
uranusjr
approved these changes
Jul 23, 2021
|
Conflicts as expected. Could you help resolve these? (I just tried resolving conflicts on GitHub and it seems to break CI triggers 😞 on other PRs) |
|
@uranusjr Can I close this PR because |
|
Oh! Maybe I did that as a part of the pkg_resources rewriting PR and didn't notice. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pip/_internal/metadata#10124.iter_dependenciesto type annotations.