pip uses deprecated SafeConfigParser

[dchudz]

• Pip version: 9.0.1
• Python version: 3.6.1
• Operating system: Mac OS X 10.12.4

Description:

With error::DeprecationWarning in PYTHONWARNINGS:

pip uninstall -y faker
/Users/davidchudzicki/.cache/hypothesis-build-runtimes/.tox/py36-full/lib/python3.6/site-packages/pip/pep425tags.py:260: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses
  import imp
Exception:
Traceback (most recent call last):
  File "/Users/davidchudzicki/.cache/hypothesis-build-runtimes/.tox/py36-full/lib/python3.6/site-packages/pip/basecommand.py", line 215, in main
    status = self.run(options, args)
  File "/Users/davidchudzicki/.cache/hypothesis-build-runtimes/.tox/py36-full/lib/python3.6/site-packages/pip/commands/uninstall.py", line 76, in run
    requirement_set.uninstall(auto_confirm=options.yes)
  File "/Users/davidchudzicki/.cache/hypothesis-build-runtimes/.tox/py36-full/lib/python3.6/site-packages/pip/req/req_set.py", line 346, in uninstall
    req.uninstall(auto_confirm=auto_confirm)
  File "/Users/davidchudzicki/.cache/hypothesis-build-runtimes/.tox/py36-full/lib/python3.6/site-packages/pip/req/req_install.py", line 732, in uninstall
    config = configparser.SafeConfigParser(**options)
  File "/Users/davidchudzicki/.cache/hypothesis-build-runtimes/versions/python3.6/lib/python3.6/configparser.py", line 1212, in __init__
    DeprecationWarning, stacklevel=2
DeprecationWarning: The SafeConfigParser class has been renamed to ConfigParser in Python 3.2. This alias will be removed in future versions. Use ConfigParser directly instead.

[pradyunsg]

Hey @dchudz! Thanks for filing this issue!

I don't see this exact same line in master but there's definitely something similar to this in the codebase today.

[pradyunsg]

This issue is a good starting point for anyone who wants to help out with pip's development -- it's simple and the process of fixing this should be a good introduction to pip's development workflow. :)

[brycepg]

This particular SafeConfigParser was removed in d64b871

There is however another one

src/pip/_internal/vcs/mercurial.py
36:        config = configparser.SafeConfigParser()

[dchudz]

Ah thanks/sorry @brycepg! I should have checked master and not just the latest release.

[pradyunsg]

There is however another one

Great! I guess that is still something that needs fixing. :)

[kaikulimu]

Could you move this to "In Progress" in https://github.com/orgs/pypa/projects/1 ?

[pradyunsg]

Done! :)

[pradyunsg]

This is back in the open pool. The relevant line of code that needs to be updated is:

pip/src/pip/_internal/vcs/mercurial.py

Line 50 in bb14ff4

config = configparser.SafeConfigParser()

[abhyudaypratap]

can I work on this issue?
I would like to help.

[pradyunsg]

I think this got fixed at some point or there's an open PR for this.

[pradyunsg]

@abhyudaypratap Thanks for volunteering! I'd forgotten to click the merge button on an existing PR for this.

Would you be willing to look at #6471, #6472 or #6473?

[abhyudaypratap]

@pradyunsg Thank you, will look into the issues 👍