pip's vendored pkg_resources should stop using pkgutil.ImpImporter

[warsaw]

Description

pkgutil.ImpImporter has been deprecated since Python 3.3. It is slated to be removed in Python 3.12 but until pip no longer uses it, we probably can't remove this long deprecated class.

Expected behavior

No response

pip version

22.2.2

Python version

3.12

OS

macOS

How to Reproduce

1. Grab the CPython branch: gh pr checkout 98059
2. configure && make test
3. test_venv fails because pip uses this API
4. See https://github.com/python/cpython/actions/runs/3215689824/jobs/5256965254

Output

No response

Code of Conduct

• I agree to follow the PSF Code of Conduct.

[warsaw]

pip also needs to remove its reference to importer.find_module() as that API is also slated for removal.

[pradyunsg]

Thanks for filing this @warsaw!

This module is under _vendor, so... it comes from a different project that pip uses. Looking into this, they're still referenced in upstream setuptools:

• https://github.com/pypa/setuptools/blob/2d4ebde71ce9daf914318f5ff29bcc39507b2cdf/pkg_resources/__init__.py#L2191
• https://github.com/pypa/setuptools/blob/2d4ebde71ce9daf914318f5ff29bcc39507b2cdf/pkg_resources/__init__.py#L2232

I believe this needs to get fixed there, and we'll pick up the fix once it's made there. :)

[pradyunsg]

@warsaw Could you file an issue against https://github.com/pypa/setuptools for this?

[pradyunsg]

/cc @jaraco for visibility, since setuptools "owns" pkg_resources and would need to make the relevant changes on this front.

[pradyunsg]

/cc @pfmoore for awareness as the current RM -- to be clear, I don't know this affects any of the plans for the current release. I'm flagging this for awareness since there is, maybe, a chance that there's a setuptools release after we make this time's round of updates and before the release, in which case we might want to run another vendoring update. :)

[warsaw]

@warsaw Could you file an issue against https://github.com/pypa/setuptools for this?

Thanks @pradyunsg; I'll do this, although I'm not sure how to figure out which version of setuptools pip is currently vendoring. I'll just file this against the latest, i.e. 65.4.1

[warsaw]

See the referenced setuptools issue above. And thanks for working on this!