Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

July 2022 release (22.2) #11238

Closed
pradyunsg opened this issue Jul 8, 2022 · 35 comments
Closed

July 2022 release (22.2) #11238

pradyunsg opened this issue Jul 8, 2022 · 35 comments
Assignees
Labels
type: maintenance Related to Development and Maintenance Processes

Comments

@pradyunsg
Copy link
Member

It's another quarter, another release.

@pradyunsg pradyunsg added the type: maintenance Related to Development and Maintenance Processes label Jul 8, 2022
@pradyunsg pradyunsg added this to the 22.2 milestone Jul 8, 2022
@pradyunsg
Copy link
Member Author

Who wants to be release manager for this one? :)

It's due by the end of this month and we have 6 PRs that are open and still in this milestone. We have one deprecation-related removal, which I'll file a PR for today.

@sbidoul
Copy link
Member

sbidoul commented Jul 8, 2022

As I will not be available to do 22.3 in October, I'm happy to take this one.

I plan to do it between the 21st and 24th, assuming some other maintainers would be around to help handle any fallout of the riskiest features.

@sbidoul
Copy link
Member

sbidoul commented Jul 14, 2022

I tried the vendoring upgrade and our patch to requests does not apply cleanly.

IIUC #10174, this patch is to make requests use chardet instead of charset_normalizer, and it was done because html5lib requires chardet ?

Now that our use of html5lib has been behind a deprecated feature flag for 2 releases, maybe we should drop html5lib now, and vendor charset_normalizer instead ?

@pradyunsg
Copy link
Member Author

Looks like that was the plan in #10825, so let’s do that!

@sbidoul
Copy link
Member

sbidoul commented Jul 18, 2022

Now that our use of html5lib has been behind a deprecated feature flag for 2 releases, maybe we should drop html5lib now, and vendor charset_normalizer instead ?

Update: in the end I dropped html5lib, but I did not vendor charset_normalizer because we vendor pygments which also tries to import chardet. Granted, pygments is a dependency of rich and we don't use it, but I did not feel like doing additional patching of vendored dependencies right now.

@sbidoul
Copy link
Member

sbidoul commented Jul 18, 2022

Alright, almost there. I plan to release on Thursday.

If there is anything else that is ready to go in, let me know.

@pradyunsg do you plan to release a new version of packaging by then ?

@pradyunsg pradyunsg pinned this issue Jul 19, 2022
@sbidoul
Copy link
Member

sbidoul commented Jul 20, 2022

I'm drafting the announcement at https://hackmd.io/Wie2Ge87SZKKoaimYA4ppw. @pypa/pip-committers your input is welcome.

@pfmoore
Copy link
Member

pfmoore commented Jul 20, 2022

LGTM 🙂

@sbidoul
Copy link
Member

sbidoul commented Jul 21, 2022

Uploading to PyPI now.

@sbidoul
Copy link
Member

sbidoul commented Jul 21, 2022

get-pip updated and annoucement posted.

Everything went smoothly. Kudos for the release process, @pradyunsg !

I'll do the cpython part over the weekend, if nothing horrible has happened with the release by then.

@pfmoore
Copy link
Member

pfmoore commented Jul 21, 2022

Ping me if you need a core dev to merge the ensurepip change.

@pradyunsg
Copy link
Member Author

pradyunsg commented Jul 21, 2022

I think CPython is non-trivial, since we need to update ensurepip's code. I've been procrastinating on that, but maybe the pip runner changes have eliminated the need for that?

@sbidoul
Copy link
Member

sbidoul commented Jul 21, 2022

@pradyunsg you mean python/cpython#92688 (comment) ? Is it not resolved by #11183 ?

@pradyunsg pradyunsg reopened this Jul 21, 2022
@pradyunsg
Copy link
Member Author

pradyunsg commented Jul 21, 2022

Yup, and I misremembered the cause of the issue! (just like I mistapped the wrong button now)

@sbidoul sbidoul modified the milestones: 22.2, 22.2.1 Jul 21, 2022
@pradyunsg
Copy link
Member Author

pradyunsg commented Jul 22, 2022

There's some discussion about a breakage due to an interaction of pip 22.2's new importlib-based injection and setuptools' distutils injection in #11294. I'll file a PR if the discussion results in a conclusion that we need to change something on our end.

@sbidoul
Copy link
Member

sbidoul commented Jul 22, 2022

Note to self: python 3.11.b5 is expected on Monday 2022-07-25, and rc1 the week after.

@sbidoul
Copy link
Member

sbidoul commented Jul 23, 2022

Alright, nothing dramatic happened with 22.2, but still there will be a 22.2.1. So I'm not sure if I should push 22.2 to CPython now, or wait a little bit until #11238 (comment) and #11288 land.

@pradyunsg
Copy link
Member Author

pradyunsg commented Jul 23, 2022

My 2c: Let's get 22.2 included, since we missed the last pip upgrade being included in ensurepip. That way, even if 22.2.1 doesn't go in by the time the next Python beta comes out, at least we'll have a version of pip that uses sysconfig out-of-the-box be a part of CPython.

@sbidoul
Copy link
Member

sbidoul commented Jul 24, 2022

My 2c: Let's get 22.2 included, since we missed the last pip upgrade being included in ensurepip. That way, even if 22.2.1 doesn't go in by the time the next Python beta comes out, at least we'll have a version of pip that uses sysconfig out-of-the-box be a part of CPython.

Makes sense. I'll do that right now.

Question: shall I upgrade the bundled setuptools at the same time? Or is it something the setuptools maintainers should do?

@pradyunsg
Copy link
Member Author

pradyunsg commented Jul 24, 2022

I don't think we've updated setuptools the last couple of times (we hit issues IIRC), and I'd defer to the setuptools maintainers for that.

The last time -- I upgraded setuptools and I filed a separate PR for it. That's probably the way to go here, in case it ends up staying open due to some compatibility issue from the setuptools upgrade. The last setuptools upgrade was reverted for a similar reason, and that's what I'd remembered when I wrote the initial comment here.

@sbidoul
Copy link
Member

sbidoul commented Jul 24, 2022

Alright, so I filed python/cpython#95195 for pip, and I'll do setuptools when that one is merged (since they would likely conflict with each other).

@pradyunsg
Copy link
Member Author

They won't -- they either modify different files or completely disjoint set of lines in the same file. :)

@pfmoore
Copy link
Member

pfmoore commented Jul 24, 2022

ensurepip updates for pip and setuptools have now been merged into main, 3.11 and 3.10 branches.

@pradyunsg
Copy link
Member Author

Hurrah! Thanks for doing that @pfmoore and @sbidoul! ^>^

@sbidoul
Copy link
Member

sbidoul commented Jul 25, 2022

@pypa/pip-committers for the time being, could you merge to main only things that need to go in 22.2.1 ? That will save me some chrerry-picking work.

@sbidoul
Copy link
Member

sbidoul commented Jul 27, 2022

I just released 22.2.1.

@pfmoore the CPython PR is python/cpython#95340

@pfmoore
Copy link
Member

pfmoore commented Jul 27, 2022

... and it's merged into CPython

@sbidoul sbidoul removed this from the 22.2.1 milestone Jul 27, 2022
@pradyunsg
Copy link
Member Author

@sbidoul Do you want us to hold off on merging PRs further, or is main open for regular development? :)

@sbidoul
Copy link
Member

sbidoul commented Jul 29, 2022

Things I know of that may require a 22.2.2 are #11319, #11314 and #11288. But I don't know if nor when that will happen or warrant a patch release.

So yes, I think we can open main for regular development.

@sbidoul sbidoul added this to the 22.2.2 milestone Jul 29, 2022
@sbidoul
Copy link
Member

sbidoul commented Aug 1, 2022

We got 3 issues fixed in the 22.2.2 milestone. If nothing else shows up, I'll cut the release later this week, and this will hopefully close the 22.2 cycle.

@sbidoul
Copy link
Member

sbidoul commented Aug 3, 2022

And 22.2.2 is out.

@pfmoore here is the cpython PR: python/cpython#95610

@sbidoul sbidoul removed this from the 22.2.2 milestone Aug 3, 2022
@pfmoore
Copy link
Member

pfmoore commented Aug 3, 2022

Merged into main, 3.11 and 3.10

@pradyunsg
Copy link
Member Author

@sbidoul Is there anything else needed here, or can we close out this release cycle? :)

@pradyunsg
Copy link
Member Author

I believe he's AFK for the near future, and we can reopen this if there's need for another bugfix.

@pradyunsg pradyunsg unpinned this issue Aug 26, 2022
@sbidoul
Copy link
Member

sbidoul commented Aug 28, 2022

I'm a aware of #11352 (which is a minor regression on python 3.11) and I'm keeping an eye on #11349 (which is unexplained so far). At this stage I'm good with closing the 22.2 cycle unless there is something important to include in the Python 3.11 release.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: maintenance Related to Development and Maintenance Processes
Projects
None yet
Development

No branches or pull requests

3 participants