Skip to content

Commit

Permalink
Removing type ignore comments from cli.progress_bars
Browse files Browse the repository at this point in the history
  • Loading branch information
deveshks committed Apr 10, 2020
1 parent 720c77a commit ed709c1
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 8 deletions.
1 change: 1 addition & 0 deletions news/770AC380-E84F-44C7-A20C-CD31A829EDA5.trivial
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Remove "type: ignore" comments from cli subpackage
17 changes: 9 additions & 8 deletions src/pip/_internal/cli/progress_bars.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ def __init__(self, *args, **kwargs):
"""
Save the original SIGINT handler for later.
"""
# https://github.com/python/mypy/issues/5887
super(InterruptibleMixin, self).__init__( # type: ignore
*args,
**kwargs
Expand Down Expand Up @@ -134,6 +135,7 @@ class DownloadProgressMixin(object):

def __init__(self, *args, **kwargs):
# type: (List[Any], Dict[Any, Any]) -> None
# https://github.com/python/mypy/issues/5887
super(DownloadProgressMixin, self).__init__( # type: ignore
*args,
**kwargs
Expand Down Expand Up @@ -183,6 +185,7 @@ def __init__(self, *args, **kwargs):
if WINDOWS and self.hide_cursor: # type: ignore
self.hide_cursor = False

# https://github.com/python/mypy/issues/5887
super(WindowsMixin, self).__init__(*args, **kwargs) # type: ignore

# Check if we are running on Windows and we have the colorama module,
Expand All @@ -206,30 +209,27 @@ class BaseDownloadProgressBar(WindowsMixin, InterruptibleMixin,
message = "%(percent)d%%"
suffix = "%(downloaded)s %(download_speed)s %(pretty_eta)s"

# NOTE: The "type: ignore" comments on the following classes are there to
# work around https://github.com/python/typing/issues/241


class DefaultDownloadProgressBar(BaseDownloadProgressBar,
_BaseBar):
pass


class DownloadSilentBar(BaseDownloadProgressBar, SilentBar): # type: ignore
class DownloadSilentBar(BaseDownloadProgressBar, SilentBar):
pass


class DownloadBar(BaseDownloadProgressBar, # type: ignore
class DownloadBar(BaseDownloadProgressBar,
Bar):
pass


class DownloadFillingCirclesBar(BaseDownloadProgressBar, # type: ignore
class DownloadFillingCirclesBar(BaseDownloadProgressBar,
FillingCirclesBar):
pass


class DownloadBlueEmojiProgressBar(BaseDownloadProgressBar, # type: ignore
class DownloadBlueEmojiProgressBar(BaseDownloadProgressBar,
BlueEmojiBar):
pass

Expand All @@ -240,7 +240,8 @@ class DownloadProgressSpinner(WindowsMixin, InterruptibleMixin,
file = sys.stdout
suffix = "%(downloaded)s %(download_speed)s"

def next_phase(self): # type: ignore
def next_phase(self):
# type: () -> str
if not hasattr(self, "_phaser"):
self._phaser = itertools.cycle(self.phases)
return next(self._phaser)
Expand Down

0 comments on commit ed709c1

Please sign in to comment.