allow creating wheels for editable packages

pypa · May 19, 2016 · e023083 · e023083
1 parent 5685e01
commit e023083
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 15 deletions.
diff --git a/pip/wheel.py b/pip/wheel.py
@@ -759,11 +759,8 @@ def build(self, autobuilding=False):
                 if not autobuilding:
                     logger.info(
                         'Skipping %s, due to already being wheel.', req.name)
-            elif req.editable:
-                if not autobuilding:
-                    logger.info(
-                        'Skipping bdist_wheel for %s, due to being editable',
-                        req.name)
+            elif autobuilding and req.editable:
+                pass
             elif autobuilding and req.link and not req.link.is_artifact:
                 pass
             elif autobuilding and not req.source_dir:

diff --git a/tests/unit/test_wheel.py b/tests/unit/test_wheel.py
@@ -380,16 +380,6 @@ def test_skip_building_wheels(self, caplog):
             assert "due to already being wheel" in caplog.text()
             assert mock_build_one.mock_calls == []
 
-    def test_skip_building_editables(self, caplog):
-        with patch('pip.wheel.WheelBuilder._build_one') as mock_build_one:
-            editable = Mock(editable=True, is_wheel=False, constraint=False)
-            reqset = Mock(requirements=Mock(values=lambda: [editable]),
-                          wheel_download_dir='/wheel/dir')
-            wb = wheel.WheelBuilder(reqset, Mock())
-            wb.build()
-            assert "due to being editable" in caplog.text()
-            assert mock_build_one.mock_calls == []
-
 
 class TestWheelCache: