Skip to content

Commit

Permalink
Merge pull request #9133 from NoahGorny/drop-unstable-feature-flag
Browse files Browse the repository at this point in the history
cli: Drop --unstable-feature flag
  • Loading branch information
pradyunsg authored Nov 14, 2020
2 parents 23324a6 + 62868dc commit 7aef258
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 19 deletions.
1 change: 1 addition & 0 deletions news/9133.removal.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Remove --unstable-feature flag as it has been deprecated.
7 changes: 0 additions & 7 deletions src/pip/_internal/cli/base_command.py
Original file line number Diff line number Diff line change
Expand Up @@ -199,13 +199,6 @@ def _main(self, args):
)
options.cache_dir = None

if 'resolver' in options.unstable_features:
logger.critical(
"--unstable-feature=resolver is no longer supported, and "
"has been replaced with --use-feature=2020-resolver instead."
)
sys.exit(ERROR)

if '2020-resolver' in options.features_enabled and not PY2:
logger.warning(
"--use-feature=2020-resolver no longer has any effect, "
Expand Down
12 changes: 0 additions & 12 deletions src/pip/_internal/cli/cmdoptions.py
Original file line number Diff line number Diff line change
Expand Up @@ -895,17 +895,6 @@ def check_list_path_option(options):
) # type: Callable[..., Option]


unstable_feature = partial(
Option,
'--unstable-feature',
dest='unstable_features',
metavar='feature',
action='append',
default=[],
choices=['resolver'],
help=SUPPRESS_HELP, # TODO: drop this in pip 20.3
) # type: Callable[..., Option]

use_new_feature = partial(
Option,
'--use-feature',
Expand Down Expand Up @@ -958,7 +947,6 @@ def check_list_path_option(options):
disable_pip_version_check,
no_color,
no_python_version_warning,
unstable_feature,
use_new_feature,
use_deprecated_feature,
]
Expand Down

0 comments on commit 7aef258

Please sign in to comment.