Skip to content

pyproject.toml: Unpin packaging now that pip-requirements-parser pins it #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 8, 2022
Merged

pyproject.toml: Unpin packaging now that pip-requirements-parser pins it #429

merged 2 commits into from
Dec 8, 2022

Conversation

tetsuo-cpp
Copy link
Contributor

Closes #426

@tetsuo-cpp
Copy link
Contributor Author

tetsuo-cpp commented Dec 8, 2022 •
edited
Loading

pip-requirements-parser just shipped 32.0 before which pins packaging. They have a more comprehensive fix in the works which involves vendoring LegacyVersion. Further context at: aboutcode-org/pip-requirements-parser#10.

Anyway, I think we can just unpin this for now.

@di
Copy link
Member

di commented Dec 8, 2022

We should increase the lower bound on pip-requirments-parser as well to make sure the new version is being resolved.

@woodruffw woodruffw added the dependencies Pull requests that update a dependency file label Dec 8, 2022
@woodruffw woodruffw merged commit 3aa951d into main Dec 8, 2022
@woodruffw woodruffw deleted the alex/unpin-packaging branch December 8, 2022 15:26
@ringohoffman
Copy link

Any chance a release can be generated including this PR?

@woodruffw
Copy link
Member

@ringohoffman Are you seeing errors with the latest release? 2.4.8 includes #427, which pins packaging so that pip-requirements-parser doesn't fetch a newer one.

@ringohoffman
Copy link

My mistake, I misinterpreted this PR. I'll be keeping an eye on aboutcode-org/pip-requirements-parser#10

@juanitosvq juanitosvq mentioned this pull request Dec 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@di di di approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incompatibility with packaging>=22.0: cannot import name 'LegacyVersion' from 'packaging.version'
4 participants
@tetsuo-cpp @di @ringohoffman @woodruffw