Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extraneous quotes #848

Merged
merged 3 commits into from
Nov 6, 2024
Merged

Extraneous quotes #848

merged 3 commits into from
Nov 6, 2024

Conversation

ewdurbin
Copy link
Member

While integrating latest commit in pypi/warehouse@a00fdef I noticed double ' were necessary and went to find out why.

#844 didn't catch one place where ' were being wrapped manually -> ad20c6b
I addressed a couple of other places where !r is relevant in -> 2226d1a

@brettcannon brettcannon enabled auto-merge (squash) November 6, 2024 22:29
@brettcannon brettcannon merged commit 9c66f5c into pypa:main Nov 6, 2024
30 checks passed
@brettcannon
Copy link
Member

Thanks!

@ewdurbin ewdurbin deleted the extraneous_quotes branch November 7, 2024 14:35
ewdurbin added a commit to pypi/warehouse that referenced this pull request Nov 8, 2024
ewdurbin added a commit to pypi/warehouse that referenced this pull request Nov 8, 2024
* chore(deps): bump packaging from 24.1 to 24.2

Bumps [packaging](https://github.com/pypa/packaging) from 24.1 to 24.2.
- [Release notes](https://github.com/pypa/packaging/releases)
- [Changelog](https://github.com/pypa/packaging/blob/main/CHANGELOG.rst)
- [Commits](pypa/packaging@24.1...24.2)

---
updated-dependencies:
- dependency-name: packaging
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix tests to handle new !r formatting in packaging

ref: pypa/packaging#844
ref: pypa/packaging#848

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ee Durbin <ewdurbin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants