-
Notifications
You must be signed in to change notification settings - Fork 280
chore: benchmarking suite #1059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I'm fine either way. |
|
I've also set this up as a separate repo. It works really well separately; the one issue is that testing a new version requires it to be pushed somewhere (a PR is fine). While the in-source version here allows you to make a commit but not push it anywhere. For #1082, I was curious about always stripping first, but didn't want to push that. But other than that, it's fine. This is the config file for the repo: {
"version": 1,
"project": "packaging",
"project_url": "https//github.com/pypa/packaging",
"show_commit_url": "https://github.com/pypa/packaging/commit/",
"repo": "https://github.com/pypa/packaging.git",
"environment_type": "virtualenv",
"build_command": ["python -m pip wheel -w {build_cache_dir} {build_dir}"],
"default_benchmark_timeout": 180,
"regressions_thresholds": {
".*": 0.01
},
"pythons": ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13", "3.14"]
}And you need a .gitignore, otherwise it's the same content pretty much. Oh, and this pyrpoject.toml, mostly generated by uv: [project]
name = "packaging-benchmark"
version = "0.1.0"
description = "Benchmark suite for packaging"
readme = "README.md"
requires-python = ">=3.8"
dependencies = [
"asv",
"pip",
] |
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
f1bab0b to
f7e2bae
Compare
This is the benchmarking suite I've been using, such as for https://iscinumpy.dev/post/packaging-faster. It could be a separate repository; there are good arguments for both.
asvsupports running from a separate repository and from a branch. Since I wrote it in a branch, opening it up here first to see what others think.I haven't used asv before, so open to suggestions on best practices, like if it is usually run from the top level or from a dir, and where to put stuff.