Skip to content

chore: update to using importlib.metadata for entry_points#879

Merged
webknjaz merged 1 commit into
pypa:mainfrom
henryiii:fix/entrypoints-imp
Apr 14, 2021
Merged

chore: update to using importlib.metadata for entry_points#879
webknjaz merged 1 commit into
pypa:mainfrom
henryiii:fix/entrypoints-imp

Conversation

@henryiii

Copy link
Copy Markdown
Contributor

Closes #870. I think this was the outcome of the discussion?

@henryiii henryiii force-pushed the fix/entrypoints-imp branch 2 times, most recently from 4782bfe to 4c40f45 Compare April 12, 2021 22:03
Comment thread source/conf.py Outdated
('py:func', 'find_packages'),
('py:func', 'pkg_resources.iter_entry_points'),
('py:func', 'setup'),
('py:func', 'importlib.metadata.entry_points'),

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@henryiii is it possible to add the corresponding importlib_metadata docs site to intersphinx? Or is this supposed to link stdlib?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was supposed to be stdlib, but it's stdlib in Python 3.10, so it's not showing up here yet. Maybe I could link to importlib_metadata when I mention the alternative, though.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correction: it actually does show up, I think, it's just the wrong interface until 3.10 is released.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And looks like the docs for importlib_metadata don't define functions.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a comment to remove when 3.10 is out (such that /3 points at 3.10), and added a direct link to the docs for importlib_metadata.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I noticed: https://webknjaz.github.io/intersphinx-untangled/docs.python.org/.

FWIW 3.10 doesn't seem to document this either.

P.S. There's nothing stopping us from adding 3.10 to intersphinx as a separate entry already.

@henryiii henryiii force-pushed the fix/entrypoints-imp branch from 4c40f45 to 66ef2c8 Compare April 13, 2021 14:13
@henryiii henryiii force-pushed the fix/entrypoints-imp branch from 66ef2c8 to 6dcefad Compare April 13, 2021 14:19
@webknjaz webknjaz enabled auto-merge April 14, 2021 19:41
@webknjaz webknjaz merged commit 114665c into pypa:main Apr 14, 2021
@henryiii henryiii deleted the fix/entrypoints-imp branch April 14, 2021 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mention alternatives to discover plugins via entry_points

2 participants