Mention enhanced attr: directive in single-sourcing option #1 #758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
reviewed
Jul 20, 2020
| .. code-block:: ini | ||
| [metadata] | ||
| version = attr:package.__version__ |
Member
There was a problem hiding this comment.
I believe that a whitespace after the colon is necessary
Suggested change
| version = attr:package.__version__ | |
| version = attr: package.__version__ |
(even if not, it reads better this way)
Contributor
Author
There was a problem hiding this comment.
It's not necessary, but I added it anyway.
webknjaz
approved these changes
Jul 20, 2020
Member
|
Thank you! ^>^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a note to the
setup.py-parsing option for single-sourcing project versions that setuptools'attr:directive does the same thing (without importing dependencies) starting in version 46.4.0.