Skip to content

Don't show full URL to gh-action-pypi-publish in anchor text#703

Merged
pradyunsg merged 2 commits intopypa:masterfrom
pastelmind:patch-1
Mar 7, 2020
Merged

Don't show full URL to gh-action-pypi-publish in anchor text#703
pradyunsg merged 2 commits intopypa:masterfrom
pastelmind:patch-1

Conversation

@pastelmind
Copy link
Contributor

@pastelmind pastelmind commented Mar 5, 2020

The current guide links to pypa/gh-action-pypi-publish with both the name and URL in the link text. This is unnecessary, as you can mouseover the link to see the full URL anyway. This commit improves readability by removing the URL portion from the link text.

This is what the web version of the guide currently looks like:

It will use the pypa/gh-action-pypi-publish GitHub Action https://github.com/marketplace/actions/pypi-publish

This commit changes it to:

It will use the pypa/gh-action-pypi-publish GitHub Action.

@webknjaz
Copy link
Member

webknjaz commented Mar 6, 2020

Hm, it looks like I originally wanted to link both Marketplace page and the repo...

@webknjaz
Copy link
Member

webknjaz commented Mar 7, 2020

I think I accidentally pasted that link into two places: webknjaz@a807576.

…ithub-actions-ci-cd-workflows.rst

Co-Authored-By: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@pradyunsg pradyunsg merged commit 437d77f into pypa:master Mar 7, 2020
@pradyunsg
Copy link
Member

Thanks @pastelmind!

@pastelmind pastelmind deleted the patch-1 branch February 23, 2021 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants