Fix invalid regex for entry point names#695
Conversation
|
Why? |
|
I saw that. Still, it doesn't explain why you consider it invalid. Looks ok to me. |
|
Try compiling it. |
|
Check the ERE specs, section on Bracket Expression, near the end of the section:
|
|
Okay, I see now. For the future, it's a good idea to explain things in the PR description and/or issue because if it's obvious to you it doesn't mean that it's obvious to everyone else. You just caused me to ask for the explanation twice and only then hinted to run something in the interpreter which could've been included in the very first post and would save us both (and any other reviewer) a lot of time. I'll post the log here so that nobody would need to repeat these steps to figure out what you mean: In [1]: import re
In [2]: re.compile('[\w-.]+')
[...]
error: bad character range \w-. at position 1 |
|
@webknjaz, sure I always do that for non-obvious bugs. This one seemed like an obvious typo to me. Sorry. |
|
Ahahaha. @di beat me to the merge button. ;) |
Closes #694.