mypy: Fix all index #363
Open
mypy: Fix all index #363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
commented
May 4, 2025
Comment on lines
+154
to
+156
| # type-ignore: This makes absolutes os.Pathlike unsupported in this branch. | ||
| # Either this or we don't support bytes-based paths, or we complexify this branch. | ||
| return os.path.join(new_root, pathname[1:]) # type: ignore[index] |
There was a problem hiding this comment.
There's a decision to be taken here.
- Don't support
PathLikein this branch (current behaviour) - Don't support
bytes | PathLike[bytes]in this branch
Suggested change
| # type-ignore: This makes absolutes os.Pathlike unsupported in this branch. | |
| # Either this or we don't support bytes-based paths, or we complexify this branch. | |
| return os.path.join(new_root, pathname[1:]) # type: ignore[index] | |
| # type-ignore: This makes absolutes os.Pathlike unsupported in this branch. | |
| # Either this or we don't support bytes-based paths, or we complexify this branch. | |
| return os.path.join(new_root, str(pathname)[1:]) |
- Support both, requires extra checking.
Avasam
force-pushed
the
mypy--fix-all-index
branch
from
ee70763 to
b045214
Compare
Avasam
force-pushed
the
mypy--fix-all-index
branch
from
b045214 to
a2dfd9c
Compare
Avasam
force-pushed
the
mypy--fix-all-index
branch
from
a2dfd9c to
3309838
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.