feat: Windows filtering and sets#507
Conversation
henryiii
force-pushed
the
feat/windowsfilter
branch
from
57c963d to
9128d8c
Compare
henryiii
force-pushed
the
feat/windowsfilter
branch
2 times, most recently
from
ad76134 to
550612d
Compare
Co-authored-by: Matthieu Darbois <mayeut@users.noreply.github.com>
henryiii
force-pushed
the
feat/windowsfilter
branch
from
550612d to
a99e0de
Compare
|
Any opinions? This unifies and simplifies the handling of architectures a bit, but shouldn't be controversial? Unless we want docs changes? |
joerick
left a comment
joerick
left a comment
There was a problem hiding this comment.
Other than the one note on unsupported archs, this looks good.
YannickJadoul
left a comment
YannickJadoul
left a comment
There was a problem hiding this comment.
Oops, sorry, I thought I had already seen and reviewed this!
henryiii
force-pushed
the
feat/windowsfilter
branch
from
a99e0de to
c97d3bc
Compare
This will change when #507 is merged
henryiii
force-pushed
the
feat/windowsfilter
branch
from
c97d3bc to
fce7c70
Compare
|
Pulled arch checking into one place, and now they all behave the same way - specifying an empty set or an arch that's not allowed is an error. |
That's great. Already approved, but ... yep, good to merge, if you ask me! |
|
I didn't order the includes correctly in one place, but didn't want to rebuild after pushing so added #518 instead. I can fix it though. |
| from .typing import PathOrStr | ||
|
|
||
| if sys.version_info < (3, 8): | ||
| from typing_extensions import Literal |
There was a problem hiding this comment.
Everything that goes into typing that can be backported goes here. :)
henryiii
added
the
automerge
3 participants
Followup to #482, use sets instead of lists for Archs, and make Windows handling behave more like Linux, where one arch will only use that arch. (Eventually, maybe could include ARM for windows, perhaps?).
No docs changes (yet).
I converted to sets, then added the changes from @mayeut.