Conversation
henryiii
commented
Mar 23, 2026
henryiii
commented
- chore: clean up config a bit
- chore: add an extra check
|
The azure failure: |
freakboy3742
left a comment
freakboy3742
left a comment
There was a problem hiding this comment.
I think I was tagged on this because of the iOS inclusion; but it all makes sense to me. One possible cleanup in the iOS code that avoids the need for a Ruff rule exemption.
| xbuild_tools: Sequence[str] | None, | ||
| ) -> tuple[Path, dict[str, str]]: | ||
| if build_frontend == "build[uv]" or build_frontend == "uv": | ||
| if build_frontend == "build[uv]" or build_frontend == "uv": # noqa: PLR1714 |
There was a problem hiding this comment.
No particularly strong feelings either way, I can't see any reason that the PLR1714 should be required here:
| if build_frontend == "build[uv]" or build_frontend == "uv": # noqa: PLR1714 | |
| if build_frontend in {"build[uv]", "uv"}: |
There was a problem hiding this comment.
For mypy. It can't narrow with the set expression, but it can with the current one. Might need a comment, then.
| build_frontend = build_options.build_frontend | ||
| # uv doesn't support iOS | ||
| if build_frontend.name == "build[uv]" or build_frontend.name == "uv": | ||
| if build_frontend.name == "build[uv]" or build_frontend.name == "uv": # noqa: PLR1714 |
There was a problem hiding this comment.
As above - the PLR exemption shouldn't be needed:
| if build_frontend.name == "build[uv]" or build_frontend.name == "uv": # noqa: PLR1714 | |
| if build_frontend.name in {"build[uv]", "uv"}: |
2 participants
