Skip to content

fix: virtualenv no-wheel #892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 14, 2025
Merged

Conversation

henryiii
Copy link
Contributor

@henryiii henryiii commented May 6, 2025

Adapting to the new --no-wheel deprecation. See pypa/virtualenv#2868.

@henryiii henryiii force-pushed the henryiii/fix/virtualenv branch 5 times, most recently from ff81e5d to 9697b1c Compare May 6, 2025 16:57
@layday
Copy link
Member

layday commented May 6, 2025

Are there any plans to actually remove this option or will it forever emit a deprecation warning?

@henryiii
Copy link
Contributor Author

henryiii commented May 6, 2025

April next year.

@henryiii henryiii force-pushed the henryiii/fix/virtualenv branch 2 times, most recently from f8a8a0f to 4fd546f Compare May 6, 2025 18:43
@henryiii
Copy link
Contributor Author

henryiii commented May 6, 2025

This also bumps the min versions of virtualenv to something we can test (20.11 for Python 3.9 and older, 20.17 for 3.10+), and restored testing on older virutalenv's for the -min jobs.

@henryiii
Copy link
Contributor Author

henryiii commented May 6, 2025

#891 should also be merged before a release, as I didn't add logic to restore this on 3.8, which still supports --no-wheel. So this is slightly more wasteful on 3.8.

@henryiii
Copy link
Contributor Author

henryiii commented May 6, 2025

Also, I'll have to fix coverage in a follow up. The main coverage is locked to an old commit, we need to add a token to get it working on main again. But this needs fixing to get our CI working again (minus coverage).

henryiii added 3 commits May 13, 2025 20:40
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii force-pushed the henryiii/fix/virtualenv branch from 4fd546f to 8574345 Compare May 14, 2025 00:40
@henryiii henryiii merged commit 56c005a into pypa:main May 14, 2025
63 of 64 checks passed
@henryiii henryiii deleted the henryiii/fix/virtualenv branch May 14, 2025 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants