-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump importlib metadata dependency #631
Conversation
jaraco
commented
Jun 27, 2023
- Consolidate importlib metadata import
- Rely on importlib_metadata for Python 3.9 and earlier. Fixes InvalidRequirement on Python 3.8 #630.
fa21abb
to
db02304
Compare
You'll also need to update the min version in https://github.com/pypa/build/blob/main/tests/constraints.txt. Technically, the PR looks solid - we should've consolidated the metadata import in a separate module long ago :) I don't know if we wanna add a fallback for packagers however. |
FYI, personally, I have started putting all backports into
Guessing you mean to make bootstrapping, etc easier? So we'd have a try/except around the <3.10 branch? |
I often do something similar, and I go a step further and group the compat modules by Python version, so |
Done in 72537a7. |