Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: allow skipping S3-related tests #1766

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

miketheman
Copy link
Member

Show the user how to skip S3 tests.

Show the user how to skip S3 tests.

Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.70%. Comparing base (4d020e8) to head (5e1c38d).
Report is 122 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1766      +/-   ##
==========================================
+ Coverage   79.69%   83.70%   +4.00%     
==========================================
  Files          31       33       +2     
  Lines        4324     4381      +57     
  Branches      780      783       +3     
==========================================
+ Hits         3446     3667     +221     
+ Misses        721      531     -190     
- Partials      157      183      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Mike Fiedler <miketheman@gmail.com>
@miketheman
Copy link
Member Author

I also thought a little bit about https://pypi.org/project/pytest-minio-mock/ - that might be a more interesting long-term idea, so no real minio server has to be running for tests.

Copy link
Contributor

@cooperlees cooperlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks for this. Will make easier for people not touching S3.

I would totally move a mocked library to make these unit tests again ...

  • But I worry about over mocking hiding issues these integration tests have found - e.g. auth setting bugs etc.

@cooperlees cooperlees merged commit ee74573 into pypa:main Jul 3, 2024
11 checks passed
@miketheman miketheman deleted the miketheman/skip-s3 branch July 3, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants