-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite mirror configuration documentation #1669
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
9925ca0
Rewrite mirror configuration documentation
flyinghyrax 18fbc6e
Apply suggestions from code review
flyinghyrax d6407bf
Make internal references more consistent.
flyinghyrax e149afd
Update descriptions for 'simple-format' & 'proxy'
flyinghyrax 14d3c08
Indicate mirror options required by current implementation
flyinghyrax 592d36c
Fix example snippets et al.
flyinghyrax File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Make internal references more consistent.
- Remove explicit reference targets and use heading anchors instead - Remove file name for links to headings in the same document
- Loading branch information
commit d6407bf326a10be14e7134e4047478e092ee11d6
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not for this PR - but, If we need
root_uri
when release-files is false, maybe we should open an issue to fix that. Seems unneeded right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the current behavior is that if
release-files
is false,root_uri
will default tohttps://files.pythonhosted.org/
, so not required per-se.I'll have to check, but I suspect setting
root_uri =
andrelease-files = false
would still generate the index files with relative URLs, so I guess it's a matter of what we think the most intuitive default behavior is forrelease-files
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, lets just document what happens in this PR and if we feel we can discuss changing it in a dedicated issue.