Rework auditwheel show checks in test_manylinux.py #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With multiple manylinux images, it's not always easy to guess what the repaired wheel will be compatible with. Add a helper for the auditwheel show check that allows to relax the constraint on the expected policy as long as it's compatible with the expected one. The `strict` argument of the helper allows to choose wether the check shall be relaxed or not.
Codecov Report
@@ Coverage Diff @@
## master #295 +/- ##
=======================================
Coverage 90.99% 90.99%
=======================================
Files 20 20
Lines 1088 1088
Branches 235 235
=======================================
Hits 990 990
Misses 55 55
Partials 43 43 Continue to review full report at Codecov.
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With multiple manylinux images, it's not always easy to guess what the repaired wheel will be compatible with.
Add a helper for the auditwheel show check that allows to relax the constraint on the expected policy as long as it's compatible with the expected one.
The
strictargument of the helper allows to choose wether the check shall be relaxed or not.