Skip to content

Conversation

@p-shg
Copy link
Contributor

@p-shg p-shg commented Sep 18, 2025

Specifically using more objects, or more than one constraint, on different objects or on the same object pair. This should help newer users of holonomic constraints understand this better

All Submissions:

  • Have you followed the guidelines in our Contributing document [docs/contribution.md]?
  • Have you checked to ensure there aren't other open [Pull Requests] for the same update/change?
  • Have you opened/linked the issue related to your pull request?
  • Have you used the tag [WIP] for on-going changes, and removed it when the pull request was ready?
  • When ready to merge, have you sent a comment pinging @pariterre in it?

New Feature Submissions:

  1. Does your submission pass the tests (if not please explain why this is intended)?
  2. Did you write a proper documentation (docstrings and ReadMe)
  3. Have you linted your code locally prior to submission (using the command: black . -l120 --exclude "external/*")?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new examples for your core changes, as applicable?
  • Have you written new tests for your core changes, as applicable?

Examples include an extention of the already provided pendulum to a 2D 3 bar mechanism and a 2D 4 bar mechanism, as well as a 3D double pendulum and 2 examples of using several constraints on the same 2 solids


This change is Reviewable

@Ipuch
Copy link
Collaborator

Ipuch commented Sep 22, 2025

Add tests in test_all_exemples.py

p-shg and others added 7 commits September 25, 2025 22:26
pariterre
pariterre previously approved these changes Sep 26, 2025
Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge with master and make sure the tests pass

@pariterre reviewed 17 of 17 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @p-shg)

@pariterre pariterre changed the title [RTR] Added more examples of using holonomic constraints Added more examples of using holonomic constraints Sep 26, 2025
p-shg added 2 commits September 26, 2025 22:46
Specifically using more objects, or more than one constraint, on different objects or on the same object pair. This should help newer users of holonomic constraints understand this better
pariterre
pariterre previously approved these changes Sep 29, 2025
Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pariterre reviewed 14 of 14 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @p-shg)

@p-shg
Copy link
Contributor Author

p-shg commented Jan 8, 2026

Tests should be ok on my side
RTM ?

@p-shg p-shg changed the title Added more examples of using holonomic constraints [RTM?] Added more examples of using holonomic constraints Jan 9, 2026
Copy link
Collaborator

@Ipuch Ipuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ipuch reviewed 6 files and all commit messages.
Reviewable status: 19 of 20 files reviewed, all discussions resolved (waiting on @pariterre).

@Ipuch Ipuch merged commit 7dce904 into pyomeca:master Jan 14, 2026
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants