-
Notifications
You must be signed in to change notification settings - Fork 55
[RTM?] Added more examples of using holonomic constraints #1022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…into NewHolonomicExamples
|
Add tests in test_all_exemples.py |
Specifically using more objects, or more than one constraint, on different objects or on the same object pair. This should help newer users of holonomic constraints understand this better
pariterre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please merge with master and make sure the tests pass
@pariterre reviewed 17 of 17 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @p-shg)
Specifically using more objects, or more than one constraint, on different objects or on the same object pair. This should help newer users of holonomic constraints understand this better
pariterre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pariterre reviewed 14 of 14 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @p-shg)
|
Tests should be ok on my side |
Ipuch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ipuch reviewed 6 files and all commit messages.
Reviewable status: 19 of 20 files reviewed, all discussions resolved (waiting on @pariterre).
Specifically using more objects, or more than one constraint, on different objects or on the same object pair. This should help newer users of holonomic constraints understand this better
All Submissions:
New Feature Submissions:
black . -l120 --exclude "external/*")?Changes to Core Features:
Examples include an extention of the already provided pendulum to a 2D 3 bar mechanism and a 2D 4 bar mechanism, as well as a 3D double pendulum and 2 examples of using several constraints on the same 2 solids
This change is