Fix process registry (open-telemetry#515)

Co-authored-by: Armin Ruech <7052238+arminru@users.noreply.github.com>
pyohannes · Jan 17, 2024 · b8b6d07 · b8b6d07
1 parent 2f23918
commit b8b6d07
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 21 deletions.
diff --git a/docs/attributes-registry/process.md b/docs/attributes-registry/process.md
@@ -16,4 +16,7 @@
 | `process.owner` | string | The username of the user that owns the process. | `root` |
 | `process.parent_pid` | int | Parent Process identifier (PID). | `111` |
 | `process.pid` | int | Process identifier (PID). | `1234` |
+| `process.runtime.description` | string | An additional description about the runtime of the process, for example a specific vendor customization of the runtime environment. | `Eclipse OpenJ9 Eclipse OpenJ9 VM openj9-0.21.0` |
+| `process.runtime.name` | string | The name of the runtime of this process. For compiled native binaries, this SHOULD be the name of the compiler. | `OpenJDK Runtime Environment` |
+| `process.runtime.version` | string | The version of the runtime of this process, as returned by the runtime without modification. | `14.0.2` |
 <!-- endsemconv -->
diff --git a/docs/resource/process.md b/docs/resource/process.md
@@ -62,9 +62,9 @@ In that case it MUST be interpreted as if it was `process.command_args`.
 <!-- semconv process.runtime -->
 | Attribute  | Type | Description  | Examples  | Requirement Level |
 |---|---|---|---|---|
-| `process.runtime.description` | string | An additional description about the runtime of the process, for example a specific vendor customization of the runtime environment. | `Eclipse OpenJ9 Eclipse OpenJ9 VM openj9-0.21.0` | Recommended |
-| `process.runtime.name` | string | The name of the runtime of this process. For compiled native binaries, this SHOULD be the name of the compiler. | `OpenJDK Runtime Environment` | Recommended |
-| `process.runtime.version` | string | The version of the runtime of this process, as returned by the runtime without modification. | `14.0.2` | Recommended |
+| [`process.runtime.description`](../attributes-registry/process.md) | string | An additional description about the runtime of the process, for example a specific vendor customization of the runtime environment. | `Eclipse OpenJ9 Eclipse OpenJ9 VM openj9-0.21.0` | Recommended |
+| [`process.runtime.name`](../attributes-registry/process.md) | string | The name of the runtime of this process. For compiled native binaries, this SHOULD be the name of the compiler. | `OpenJDK Runtime Environment` | Recommended |
+| [`process.runtime.version`](../attributes-registry/process.md) | string | The version of the runtime of this process, as returned by the runtime without modification. | `14.0.2` | Recommended |
 <!-- endsemconv -->
 
 How to set these attributes for particular runtime kinds is described in the following subsections.

diff --git a/model/registry/process.yaml b/model/registry/process.yaml
@@ -58,3 +58,21 @@ groups:
         brief: >
           The username of the user that owns the process.
         examples: 'root'
+      - id: runtime.name
+        type: string
+        brief: >
+          The name of the runtime of this process. For compiled native binaries,
+          this SHOULD be the name of the compiler.
+        examples: ['OpenJDK Runtime Environment']
+      - id: runtime.version
+        type: string
+        brief: >
+          The version of the runtime of this process, as returned by the runtime
+          without modification.
+        examples: '14.0.2'
+      - id: runtime.description
+        type: string
+        brief: >
+          An additional description about the runtime of the process, for example
+          a specific vendor customization of the runtime environment.
+        examples: 'Eclipse OpenJ9 Eclipse OpenJ9 VM openj9-0.21.0'
diff --git a/model/resource/process.yaml b/model/resource/process.yaml
@@ -37,21 +37,6 @@ groups:
     brief: >
       The single (language) runtime instance which is monitored.
     attributes:
-      - id: name
-        type: string
-        brief: >
-          The name of the runtime of this process. For compiled native binaries,
-          this SHOULD be the name of the compiler.
-        examples: ['OpenJDK Runtime Environment']
-      - id: version
-        type: string
-        brief: >
-          The version of the runtime of this process, as returned by the runtime
-          without modification.
-        examples: '14.0.2'
-      - id: description
-        type: string
-        brief: >
-          An additional description about the runtime of the process, for example
-          a specific vendor customization of the runtime environment.
-        examples: 'Eclipse OpenJ9 Eclipse OpenJ9 VM openj9-0.21.0'
+      - ref: process.runtime.name
+      - ref: process.runtime.version
+      - ref: process.runtime.description