Fix/1553 rtt cb not found #1583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdasika
force-pushed
the
fix/1553_rtt_CB_not_found
branch
from
fe0a450 to
8c0db06
Compare
This was referenced Jul 10, 2023
flit
requested changes
Jul 11, 2023
Member
flit
left a comment
flit
left a comment
There was a problem hiding this comment.
Just a couple small changes.
If you feel like it, please also add your copyright to the file's header comment.
Member
|
@tdasika Do you mind if I commit the requested changes to your branch so I can close out this PR? I'd like to make sure this fix is included in the next release. Thanks! |
Contributor
Author
Member
Even better! Thanks 😄 |
flit
approved these changes
Jul 31, 2023
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyocd is always searching for control_block_id with 16 bytes length (when the block id is less than 16 bytes, it is padding with ‘\0’)
So, when ‘SEGGER RTT’ is the block id to be found, it is searching for 4 words (16 bytes) with zero padding instead of 10 bytes(’SEGGER RTT’), where some junk characters may be present and resulting in failure ‘Control block not found'
Fixing it by searching for only the length of the control block ID provided while setting up rtt