Skip to content

Add license file to package source and specify min python version #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nmohr192
Copy link

I am planning to sync this package as a recipe to conda forge to install it in my conda envs, but to finalize this PR I need the tarball to contain the LICENSE file and the package to specify a minimum python version.

Please review and release to pypi! :)

@nmohr192
Copy link
Author

@JorjMcKie Could you please have a look?

@JorjMcKie
Copy link
Collaborator

We do welcome your intention to make the package available to conda.

PyMuPDF4LLM - like most other Artifex products - is double-licensed under either GNU AFFERO GPL 3.0 or commercial licenses. I will need to find a way to express this condition in the package and include the license file. The next version 0.0.26 should be fine in that respect.

As per the supported Python versions, this is identical to what PyMuPDF itself does:

We are supporting all Python versions that are actively maintained by the PSF (Python Software Foundation) at any point in time.
As per today, this includes versions 3.9 and up (without upper limit). In October of this year, Python 3.9 will drop out of PSF's supported versions and thus the same thing will happen in PyMuPDF4LLM / PyMuPDF. In other words, with the first first version published after October 1, 2025 we will support Python 3.10 and up only (i.e. specifically including Python 3.14).
The same mechanism will repeat in October of all years to come - as long as PSF sticks with this scheme.

@JorjMcKie
Copy link
Collaborator

Once version 0.0.26 is on PyPI I will close this PR.

Thanks again for contributing it and considering PyMuPDF4LLM!

@nmohr192
Copy link
Author

Hi Jorj, thanks for your response.
Do you have a rough ETA for 0.0.26 release?

If you close this PR, then please ensure the License is part of the tarball release to pypi for the conda recipe integration, and the minimum python version is mentioned at least in the setup.py for your 0.0.26 release.

Thanks

@JorjMcKie
Copy link
Collaborator

Sure - I have local wheel and tarball files that look good.
The new version should up before end of the week.
You are aware that pymupdf4llm has a dependency on pymupdf? And the version 0.0.26 now also checks at execution time that the dependency is met with the specified pymupdf version.

@nmohr192
Copy link
Author

Sounds good, thanks :) I am aware of this (see my PR in the conda repo here). It's a bit unfortunate, that conda-forge only offers linux version for pymupdf, even though it's noarch on pypi. This means that pymupdf4llm can also only be published as linux only to conda-forge, or I also have to create a PR for updating pymupdf on conda-forge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants