Various changes #2936
Merged
Various changes #2936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extra diagnostics are enabled if PYMUPDF_EXCEPTIONS_VERBOSE is 2.
mupdf-1.23.7 seems ok, mupdf master causes us problems.
This is for pymupdf#2907, 'segfault trying to call clean_contents on certain pdfs with python 3.12'. We are not intending to fix this bug, so actually this test only runs on rebased.
Was previously set to mupdf version.
…v().
venv():
added `venv_quick` option, small speed up if venv directory already exists.
log():
show caller path and fn name.
…o run. Also don't print python backtrace after subprocess errors, as not usually useful.
Simplified command line to be <options> followed by <commands>.
New options:
-b: set build type (e.g. debug).
-d: set debug build.
-i: set pymupdf implementations to test.
-m: same as --mupdf, sets location of mupdf.
-p: set pytest options.
-t: set pytest test file/function.
-v: save time if venv directory already exists.
If tests fail, show information about re-running tests manually in venv.
Don't show python backtrace of subprocess errors, as not useful.
Avoid problems on github with valgrind tests, where classic cannot find libmupdf.so if PyMuPDF checkout is the current directory.
JorjMcKie
approved these changes
Dec 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various minor things. And:
fitz.pymupdf_version_tuple.scritps/test.py: Lots of improvements and new options, to help investigating mupdf issues.fitz_oldwhen current directory is PyMuPDF directory.