Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving Japanese document for better translations and Fixing typos in document #2700

Closed
wants to merge 10 commits into from

Conversation

mackey0225
Copy link
Contributor

The other day, I was thrilled to see the Japanese version of the document being provided and made public.
However, I noticed a minor issue in the translation that bothered me, so I made some corrections.

Specifically, "joining and merging" had been translated as "結合と結合," which was a repetition of the same word. I made a slight adjustment to address this.

Furthermore, while reviewing the document, I found several typos and made corrections accordingly.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2023

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


1 out of 2 committers have signed the CLA.
@mackey0225
@masano-bj
You can retrigger this bot by commenting recheck in this Pull Request

@mackey0225
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@mackey0225
Copy link
Contributor Author

recheck

@jamie-lemon
Copy link
Collaborator

jamie-lemon commented Oct 10, 2023

Thanks - I'm glad you appreciate the Japanese version of the docs!

I appreciate your suggestion for: 結合とマージ - makes sense to me.

If possible could you redo this PR and remove the edits to the source .po files. This is because the .po files are auto-generated from the corresponding .rst files and so those new amends you made to the .rst files which fix the typos will be auto-amend to their corresponding .po files when we run the generate script again. ( I also have some fixes for other rst files and intend to apply an update to address some other things ).

So, TLDR, please remove the .po fixes, we can merge this and then I'll auto-generate the .po files and add the correct msgstr logs against the new msgid items.

Hope this makes sense.

@jamie-lemon jamie-lemon self-requested a review October 10, 2023 21:37
@mackey0225
Copy link
Contributor Author

Regarding the .po file, I understand.
I made some mistakes during the corrections, such as using the wrong GitHub account for the commit,
so I have recreated the PR #2733 .
I would appreciate it if you could review this.

@mackey0225 mackey0225 closed this Oct 11, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants