Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation for "table" feature #2599

Closed
wants to merge 7 commits into from
Closed

Conversation

JorjMcKie
Copy link
Collaborator

Documents new Page method find_tables().

Documents new age` method `find_tables()`.
docs/page.rst Outdated

* **bbox:** the bounding box of the table as a tuple `(x0, y0, x1, y1)`.
* **cells:** bounding boxes of the table's cells (list of tuples). A cell may also be `None`.
* **extract:** a method returning the text content of each table cell (a list of list of strings).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a list of list of ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant "list of lists of" - i.e. something in type annotation List[List[String]]. Not sure if we want to use this instead ...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aha - gotcha - yes, I think the code sample would clarify it as a double nested array kind of thing.

Copy link
Collaborator

@jamie-lemon jamie-lemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one typo I think - otherwise LGTM ;)

Copy link
Collaborator

@jamie-lemon jamie-lemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one tiny typo in recipes-text.rst

@JorjMcKie
Copy link
Collaborator Author

I think I have resolved the conflicts ...

@jamie-lemon jamie-lemon deleted the document-table-feature branch August 25, 2023 16:27
@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants