-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-support font name prefixes in span font names #896
Comments
Ok, I understand. |
That solution sounds great. Thanks for the suggestion |
It is easy-peasy to do. At least for the dict / json / rawdict / rawjson outputs. |
Excellent, thanks so much, that looks perfect |
You can find Linux and Mac OSX pre-version wheels in respective branches of this repo. |
Sorry for not getting back to you sooner. This worked exactly as expected thanks |
I am planning to publish an official new version with a week from now. |
Fixed in v1.18.9 currently being uploaded. |
Thanks again for this, it worked as expected. |
Is your feature request related to a problem? Please describe.
Before version
1.17.6
when you extracted the page text dict you would get font names likeMJGHPI+TimesNewRomanPSMT
and
YCCJKF+TimesNewRomanPSMT
Now those same text spans both return
TimesNewRomanPSMT
Note the lack of leading prefix
This is a breaking change for our current implementation and we can not upgrade beyond
1.17.5
until we can specify that full font-names should be used.This is the line that was changed
https://github.com/pymupdf/PyMuPDF/compare/60e0c1fd5abadf61905253ea2fa19f62cb28e66e..10341cea796e8cbde86959a590d87b2596c27085#diff-04606915a2aa7f21b7798f15aba6f7b29a8900c7ac7403b13f2237f8214749ecR184
Describe the solution you'd like
It would nice to be be able to do one of the following:
get_text("dict")
that specifies that font names should be returned as isDescribe alternatives you've considered
I explored option 2 above but I don't currently think that's possible
Additional context
If you think this is something that is in-line with the project's vision I will happily implement it.
The text was updated successfully, but these errors were encountered: