Initialising Archive with a pathlib.Path fails. #3126
Labels
Comments
|
Thanks for the report. I agree that we are incorrectly using the leafname, which means that we will usually not find the intended file or directory. We'll have an internal discussion about how best to make things work, and hopefully release a fix maybe early next week. |
julian-smith-artifex-com
added a commit
to ArtifexSoftware/PyMuPDF-julian
that referenced
this issue
Feb 6, 2024
src/__init__.py:
Simplified the logic so we systematically switch on the type of
`content`. This also avoids behaviour depending on whether str(content)
(when content is not itself a string) happens to match an existing file or
directory.
Also removed the local variables and pass params explicitly to local fn
`make_subarch()`.
Also use `assert` if we are passed incorrect types, instead of explicitly
raising an exception.
tests/test_general.py:
Added test_archive_3126() for pymupdf#3126.
julian-smith-artifex-com
added a commit
to ArtifexSoftware/PyMuPDF-julian
that referenced
this issue
Feb 10, 2024
src/__init__.py:
Simplified the logic so we systematically switch on the type of
`content`. This also avoids behaviour depending on whether str(content)
(when content is not itself a string) happens to match an existing file or
directory.
Also removed the local variables and pass params explicitly to local fn
`make_subarch()`.
Also use `assert` if we are passed incorrect types, instead of explicitly
raising an exception.
tests/test_general.py:
Added test_archive_3126() for pymupdf#3126.
julian-smith-artifex-com
added a commit
that referenced
this issue
Feb 13, 2024
src/__init__.py:
Simplified the logic so we systematically switch on the type of
`content`. This also avoids behaviour depending on whether str(content)
(when content is not itself a string) happens to match an existing file or
directory.
Also removed the local variables and pass params explicitly to local fn
`make_subarch()`.
Also use `assert` if we are passed incorrect types, instead of explicitly
raising an exception.
tests/test_general.py:
Added test_archive_3126() for #3126.
julian-smith-artifex-com
added a commit
that referenced
this issue
Feb 14, 2024
src/__init__.py:
Simplified the logic so we systematically switch on the type of
`content`. This also avoids behaviour depending on whether str(content)
(when content is not itself a string) happens to match an existing file or
directory.
Also removed the local variables and pass params explicitly to local fn
`make_subarch()`.
Also use `assert` if we are passed incorrect types, instead of explicitly
raising an exception.
tests/test_general.py:
Added test_archive_3126() for #3126.
|
Fixed in 1.23.23. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Creating an instance of an
Archivewith apathlib.Pathfails with a ValueError "bad archive content".Debugging the code, I suspect the following lines are responsible:
PyMuPDF/src/__init__.py
Lines 1749 to 1752 in 4d604d6
Since a
Pathobject has an attributename(and given that's checked first), thecontentvariable receives the final path component.Therefore, when the code checks if
contentis either a directory or file (lines 1754 and 1762), it will only be true if the final path element is either a subdirectory or file in the directory where the__init__.pyfile resides.I tried inverting the conditions of the if and elif statements on the cited snippet, i.e check if
contentis an instance ofPathbefore checking it has the attributename, and it worked. However, given my limited knowledge of the library, I'm not sure if this would break in other scenarios.The text was updated successfully, but these errors were encountered: