Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insert_image: document that rotations are counterclockwise #2275

Closed
cbm755 opened this issue Mar 5, 2023 · 2 comments
Closed

insert_image: document that rotations are counterclockwise #2275

cbm755 opened this issue Mar 5, 2023 · 2 comments

Comments

@cbm755
Copy link
Contributor

cbm755 commented Mar 5, 2023

Docs for insert_image:

rotate (int) – (new in version v1.14.11) rotate the image. Must be an integer multiple of 90 degrees. If you need a rotation by an arbitrary angle, consider converting the image to a PDF (Document.convert_to_pdf()) first and then use Page.show_pdf_page() instead.

It would be helpful if this said "rotate the image counter-clockwise."

(I've just spent some time debugging something that mixes mogrify (cw), PIL (ccw) and fitz (ccw); it would be helpful to have these things written down in the docs).


Sorry for not sending a PR; but it would be good for someone to double-check that I'm right ;-)

@JorjMcKie
Copy link
Collaborator

Accepted. As is customary, throughout PDF at least, positive angles rotate counter-clockwise, negative angles are clockwise.

@julian-smith-artifex-com
Copy link
Collaborator

I have updated the docs in my tree to mention this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants