Skip to content

Update classifiers for pypi #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janiversen merged 1 commit into from
May 22, 2022
Merged

Update classifiers for pypi #907

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,19 @@ long_description = file: README.rst, CHANGELOG.rst, LICENSE
url = 'https://github.com/riptideio/pymodbus/'
classifiers =
Development Status :: 4 - Beta
Programming Language :: Python :: 3.8 :: 3.9 :: 3.10
Programming Language :: Python :: 3.8
Programming Language :: Python :: 3.9
Programming Language :: Python :: 3.10
Environment :: Console
Framework :: Twisted :: Tornado :: Asyncio
Intended Audience :: Developers :: Modbus testers
Framework :: Asyncio
Intended Audience :: Developers
License :: OSI Approved :: BSD License
Operating System :: OS Independent :: Linux :: Windows :: Mac OS
Programming Language :: Python :: 3.8
Topic :: System :: Networking :: Utilities :: SCADA :: Modbus
Operating System :: OS Independent :: Linux
Copy link
Contributor

@dhoomakethu dhoomakethu May 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no Operating System :: OS Independent :: Linux , we can use Operating System :: POSIX :: Linux

Copy link
Contributor

@dhoomakethu dhoomakethu May 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the working diff

index 6d4e6433..94c61680 100644
--- a/setup.cfg
+++ b/setup.cfg
@@ -9,17 +9,26 @@ platforms        = 'Linux', 'Mac OS X', 'Win'
 description      = "A fully featured modbus protocol stack in python"
 keywords         = 'modbus, asyncio, scada, client, server, simulator'
 long_description = file: README.rst, CHANGELOG.rst, LICENSE
-url              = 'https://github.com/riptideio/pymodbus/'
-classifiers      =
+url              = https://github.com/riptideio/pymodbus/
+classifiers      =
     Development Status :: 4 - Beta
-    Programming Language :: Python :: 3.8 :: 3.9 :: 3.10
     Environment :: Console
-    Framework :: Twisted :: Tornado :: Asyncio
-    Intended Audience :: Developers :: Modbus testers
+    Framework :: Twisted
+    Framework :: AsyncIO
+    Intended Audience :: Developers
     License :: OSI Approved :: BSD License
-    Operating System :: OS Independent :: Linux :: Windows :: Mac OS
+    Operating System :: POSIX :: Linux
+    Operating System :: Unix
+    Operating System :: MacOS :: MacOS X
+    Operating System :: OS Independent
+    Operating System :: Microsoft
     Programming Language :: Python :: 3.8
-    Topic :: System :: Networking :: Utilities :: SCADA :: Modbus
+    Programming Language :: Python :: 3.9
+    Programming Language :: Python :: 3.10
+    Programming Language :: Python :: 3.11
+    Programming Language :: Python :: 3.12
+    Topic :: System :: Networking
+    Topic :: Utilities
 project_urls     =
     Source Code  = https://github.com/riptideio/pymodbus
     Bug Reports  = https://github.com/riptideio/pymodbus/issues
(END)

Copy link
Collaborator Author

@janiversen janiversen May 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for me. But should we really announce 3.11 and 3.12 ? I have not tested 3.11 and know there are problems with 3.12

Copy link
Collaborator Author

@janiversen janiversen May 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will you commit the changes directly ?

Copy link
Contributor

@dhoomakethu dhoomakethu May 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I will do it once I figure out the issue with the long_description

Copy link
Collaborator Author

@janiversen janiversen May 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have update README.rst to reflect that we now are at dev4.

Copy link
Contributor

@dhoomakethu dhoomakethu May 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool , I have the release published to Pypi https://pypi.org/project/pymodbus/3.0.0.dev4/

Copy link
Collaborator Author

@janiversen janiversen May 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, more testing for me 😃

Operating System :: POSIX :: Linux
Operating System :: Microsoft :: Windows
Operating System :: MacOS
Topic :: System :: Networking
Topic :: Utilities
project_urls =
Source Code = https://github.com/riptideio/pymodbus
Bug Reports = https://github.com/riptideio/pymodbus/issues
Expand Down