PATCH: boost serial speed 3x or more #python3 #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not initialising _last_frame_end and _silent_interval breaks test cases. We'll initialise _last_frame_end to 0.0 (to indicate the last frame is possibly a *long* time ago, connect resets it) and we set _silent_interval there since baud rate should not be changing. (cherry picked from commit 9f89bff)
Contributor
|
This branch is working great for me! Why has it been over a year and no discussion or merge? I'd really like to see it in mainline. Thanks! |
Contributor
|
Closed as part of PR #164 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python3 support for fast serial RTU. Long description can be found in pull request #55.