select proper bitness from pypy externals for windows #637
Conversation
altendky
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
|
@dhoomakethu, here's a Windows PyPy fix up. |
|
@altendky its still failing for windows 3.7x. |
|
It is. I should probably take another pass at clearing that flakiness, but it is not related to the PyPy fix implemented here. |
|
@altendky I was talking about this job https://github.com/riptideio/pymodbus/pull/637/checks?check_run_id=2670955558 |
|
@dhoomakethu, yes, that is CPython and thus unrelated to the new PyPy release being 64-bit. This PR fixes the PyPy issue. I would recommend merging this fix and addressing the flaky asyncio test setup separately. I'll see if I can find some time today to look at the flaky stuff. |
|
For linkage, see #639 for work on the flaky CPython asyncio test. |
* use win64_14x from pypy externals * dynamically select pypy externals bitness * refer to pypy as python in commands
* use win64_14x from pypy externals * dynamically select pypy externals bitness * refer to pypy as python in commands
* use win64_14x from pypy externals * dynamically select pypy externals bitness * refer to pypy as python in commands
2 participants
PyPy went to 64 bit between 7.3.3 and 7.3.4 which happened between the last good build de0cc3e and the first bad one at a22932e. We need to update to use the 64-bit PyPy externals reference to get the needed libraries for building cryptography. Also, 7.3.4 dropped Python 3.6 support so our 3.6 tests will continue with 32-bit PyPy 7.3.3.