Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on Python 3.13 #2366

Merged
merged 4 commits into from
Oct 9, 2024
Merged

Test on Python 3.13 #2366

merged 4 commits into from
Oct 9, 2024

Conversation

alexrudd2
Copy link
Collaborator

No description provided.

@alexrudd2
Copy link
Collaborator Author

The problem is apparently pytest-profiling, which hasn't bothered to release since 2019... but they are apparently resurrecting.

Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@janiversen janiversen merged commit 7872420 into dev Oct 9, 2024
1 check passed
@janiversen janiversen deleted the python3.13 branch October 9, 2024 18:19
@janiversen
Copy link
Collaborator

Have not seen you for quite a while, nice to see your PR´s again.

If you feel in mypy/ruff mode, then both framer and serial, should be totally typed. Next up for me is pdu and then transaction.

You missed to change the README, to tell others that we now test on python 3.13 (Thanks for doing that!!).

@alexrudd2
Copy link
Collaborator Author

My spare development time has been porting libraries to 3.13 and pyproject.toml.

Sure, I can look at typing the new code.

@janiversen
Copy link
Collaborator

Your PR is always welcome !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants