Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly process 'slaves' argument, add explicit 'zero_mode' argument #2292

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Properly process 'slaves' argument, add explicit 'zero_mode' argument #2292

merged 1 commit into from
Aug 13, 2024

Conversation

Cavaler
Copy link
Contributor

@Cavaler Cavaler commented Aug 12, 2024

  • 'slaves' argument is not treated as a boolean anymore, but really sets the number of slaves, as its description suggested
  • added argument to explicitly set zero_mode, can be used with single slave as well

janiversen
janiversen requested changes Aug 12, 2024
View reviewed changes
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove zero_mode as the lower layers no longer support this.

examples/helper.py Outdated Show resolved Hide resolved
janiversen
janiversen reviewed Aug 13, 2024
View reviewed changes
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@janiversen janiversen merged commit 3e60a20 into pymodbus-dev:dev Aug 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janiversen janiversen janiversen requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cavaler @janiversen