Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify packet construction #2086

Closed
wants to merge 1 commit into from
Closed

Simplify packet construction #2086

wants to merge 1 commit into from

Conversation

alexrudd2
Copy link
Collaborator

Solves another mypy error, with code that is hopefully more readable (and more efficient?)

janiversen
janiversen requested changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not change this code !!!!

it is only there until we are confident that the new encoder works.

@alexrudd2 alexrudd2 closed this Mar 7, 2024
@alexrudd2 alexrudd2 deleted the remove-framer-bytearray branch March 7, 2024 02:28
@alexrudd2 alexrudd2 mentioned this pull request Mar 7, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@janiversen janiversen janiversen requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexrudd2 @janiversen