Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix for #1662 #1663

Merged
merged 3 commits into from
Jul 18, 2023
Merged

Bug fix for #1662 #1663

merged 3 commits into from
Jul 18, 2023

Conversation

fhydralisk
Copy link
Contributor

@fhydralisk fhydralisk commented Jul 18, 2023 •
edited by janiversen
Loading

Add a **kwargs init argument in ModbusTCPServer.

Also with unit test code added for this.

fixes #1662

janiversen
janiversen requested changes Jul 18, 2023
View reviewed changes
pymodbus/server/async_io.py Outdated Show resolved Hide resolved
test/test_simulator.py Show resolved Hide resolved
janiversen
janiversen approved these changes Jul 18, 2023
View reviewed changes
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

Looking forward to see more PRs from you.

@janiversen janiversen merged commit bc26449 into pymodbus-dev:dev Jul 18, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@janiversen janiversen janiversen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simulator server cannot start in current dev branch
2 participants
@fhydralisk @janiversen