Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BinaryPayloadBuilder.to_string to BinaryPayloadBuilder.encode #1526

Merged
merged 4 commits into from
Apr 25, 2023
Merged

BinaryPayloadBuilder.to_string to BinaryPayloadBuilder.encode #1526

merged 4 commits into from
Apr 25, 2023

Conversation

jamesbraza
Copy link
Contributor

Coming from #1518.

janiversen
janiversen approved these changes Apr 25, 2023
View reviewed changes
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@janiversen janiversen merged commit d8f2675 into pymodbus-dev:dev Apr 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@janiversen janiversen janiversen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesbraza @janiversen